[MERGE][#56299] New option -C/--change for diff and status to show changes in one revision.

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Lukáš Lalinský wrote:
> Here is an updated version that uses '-c' rather than '-C', and allows
> the '--change' and '--revision' options to override each other.

Nicely done!  Just a couple of things.

bb:resubmit

> +        param_name -- name of the parameter, which will be passed to

I think the comma doesn't belong here.

> +def _parse_change_str(revstr):
> +    return (revisionspec.RevisionSpec.from_string('before:' + revstr),
> +            revisionspec.RevisionSpec.from_string(revstr))

If a user does "bzr status -c 4..5", they get "ERROR: No namespace
registered for string: u'4..5'".  I think it would be better if they
got: "-c does not accept ranges" or something.

>                 type=_parse_revision_str,
>                 short_name='r',
>                 help='See \'help revisionspec\' for details.')
> +_global_option('change',
> +               type=_parse_change_str,
> +               short_name='c',
> +               param_name='revision',
> +               help='Show changes introduced by the specified revision.')

I think -c is more general than showing changes.  (For example, I'd like
to add it to merge).  Perhaps 'Select changes introduced by the
specified revision (see also "help revisionspec")'?

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG0D4y0F+nu1YWqI0RAlBcAJ49NhDVk3fBNmUZp3QHFJbNPhWm4gCfYiiO
Ojp73fbTIpEfuv/nLaekn1I=
=ZwAu
-----END PGP SIGNATURE-----