[MERGE] Support 3 noise levels in commit

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ian Clatworthy wrote:
> I don't feel I'm mis-using -q/--quiet at all. I'd argue I'm fixing a bug
> because, right now, -q doesn't do what users expect on commit

That's very different from what your subject line said.  If you're going
to introduce 3 noise levels for commit, that's one thing, and you should
do it right.  Bugfixing is a very different matter.

>>> b) "bzr commit --quiet --verbose" should select "verbose", the way the
>>> rest of our options behave.
> 
> I agree conceptually. Practically, it's a non-issue because that would
> only happen if --quiet was part of an alias (not possible right now?)

Which is a bug.  Using --silent would avoid that bug.

>>> Instead, I think it makes more sense to treat verbose as an enumeration,
>>> with --silent, --normal and --verbose as individual flags.
>>> "verbose=False" can be handled as a legacy value.
> 
> How will --silent differ from --quiet?

It will be aliasable.  It will be overridable by --normal and --verbose.

> I'm good with a 3 level enumeration assuming it's forwardly compatible
> with the implicit one in our UI already (-q, nothing, -v) and that we
> agree to adopt it across every command, not just commit.

Adopting --silent across the board would mean making it a global option,
which (given our current codebase) would make it not overridable by
- --normal and --verbose, and not aliasable.  In other words, it might as
well be --quiet if you want to make it just like quiet.

It would also mean introducing --normal and --verbose across the board,
which is probably a good idea anyhow, even if they don't do anything for
particular commands.

> This started out as a simple DWIM patch for -q/-v on commit. Does it
> need to become a "fix and test noise level selection and handling across
> the product" to get merged?

Well, decide whether you're fixing a bug or introducing a feature, and
I'll get back to you.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGzi7w0F+nu1YWqI0RAoV4AJ48VHS7uRFuLUbIb5nyux0PCavqAQCeMz4p
PsuILCulLzRGjPsgM7o6qyQ=
=D1To
-----END PGP SIGNATURE-----