[MERGE] Support 3 noise levels in commit

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Aaron Bentley wrote:
>> Ian Clatworthy wrote:
> --quiet (in the global sense) doesn't. Because of when aliases are
> parsed versus when global arguments are parsed, you can't add a global
> arg to aliases.

Okay, I think that's a deal-breaker.

bb:resubmit

> That said, I think '--quiet' should have an effect on commit. I don't
> think he is mis-using it to have that sort of effect.

If we're treating it as a boolean, sure.  But if you're talking about
having three different levels of verbosity, then they have to be
closer-related than this.  Maybe you have a global verbosity control, I
dunno.

> Again, global options muddy the waters here. We need to change how we
> parse those before we can have that sort of effect.

Agreed.

>>> -            self._report_change(ie, path)
>>> +            if self.reporter.is_verbose():
>>> +                self._report_change(ie, path)
>> ^^^ is this really a win?  You don't have newer function calls.  You may
>> have *more*, in fact.
> 
> I think it would be a net win if you cached the result in a local
> variable, but otherwise I agree that you end up with 2 calls instead of 1.

Or you could even run different loops depending on the value of
reporter.is_verbose.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGzd2A0F+nu1YWqI0RAtlZAJ9v9YrUpvBMowX5kLXcMACPoNr4ggCggX5c
WTl505gzINpH0nofQKNGk38=
=nKhf
-----END PGP SIGNATURE-----