[MERGE] Fix for Bug 129299, BZR_PLUGIN_PATH should ignore trailiing slashes.

[Blake Winton]

Blake Winton wrote:
> Aaron Bentley wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Your changes have a failing test case:
>> Traceback (most recent call last):
>>   File "/home/abentley/bzr/foo/bzrlib/tests/test_plugins.py", line 76,
>> in test_plugins_with_the_same_name_are_not_loaded
>>     self.assertEqual(['first'], self.activeattributes[tempattribute])
>> AssertionError: not equal:
>> a = ['first']
>> b = []
> 
> This is an interesting one...  If I change the name of my test to 
> test_plugins_zzzcan_load_from_directory_with_trailing_slash, then all of 
> a sudden this test succeeds and my test fails.
> 
> Anyone have any ideas what's going on here?  (I'm bwinton on #bzr if you 
> need more details...)

It looks like it wasn't re-importing bzrlib.plugins.plugin, even though 
it was ostensibly deleted at the end of each method.  I've renamed the 
plugin I'm trying to load to "ts_plugin.py", and it all passes now. 
Since that was the last thing you suggested, here's a resubmit of the 
new bundle.

(I've also merged in Alexander Belchenko's suggestion, since I was 
modifying the code anyways...)

Later,
Blake.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: plugin_path4.patch
Type: text/x-patch
Size: 13124 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070823/bd605602/attachment.bin