[merge] allow for testing multiple Inventory implementations

Aaron Bentley aaron.bentley at utoronto.ca
Thu Aug 23 01:36:09 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> This reorganizes the Inventory tests to allow us to add and then test a
> new better Inventory class.  It also moves two tests for is_inside_any
> and is_inside_or_parent_of_any into test_osutils, because they're
> osutils functions and apparently not strongly related to the inventory.
> 
> At the moment these are only tested for our current Inventory class.
> 
> This builds on the previous patch to add a simpler test scenario
> interface.

bb:tweak

This all looks fine, assuming it's leading up to a new Inventory class.

> === added directory 'bzrlib/tests/inventory_implementations'
> === added file 'bzrlib/tests/inventory_implementations/__init__.py'

^^^ It's a bit unusual to add a package with nothing in it.  I realize
we often do this for plugins, but aside from that, I think it makes
sense to either do

bzrlib/tests/inventory_implementations/
bzrlib/tests/inventory_implementations/__init__.py
bzrlib/tests/inventory_implementations/basic_tests.py
bzrlib/tests/inventory_implementations/advanced_tests.py

Or else do:
bzrlib/tests/inventory_implementations.py

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGzNZ50F+nu1YWqI0RAlSoAKCIK0r4YnBdfpYTADaZPgw5wv1zZgCeNhYm
2iu0VE+9gtzEFaktNubm0qU=
=ZrYO
-----END PGP SIGNATURE-----



More information about the bazaar mailing list