[MERGE] Clarify tests in revisionstore_implementations/test_all

Robert Collins robertc at robertcollins.net
Thu Aug 23 00:24:02 BST 2007


On Thu, 2007-08-23 at 09:12 +1000, Robert Collins wrote:
> Actually, I've thought about this more, asking for a revision None is
> nuts; giving 'NoSuchRevision' for None, while true, is not really
> helpful - TypeError, which is what the check_revision_id call raises is
> better.
> 
> So I propose to change it to wanting TypeError for None.

Or better yet, I'll look around some more. Heres an incremental patch
that I think gets the balance right.

These tests really were for 'null:'. So I've done that:


-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: revision-store-incremental.patch
Type: text/x-patch
Size: 1713 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070823/9f5d12f1/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070823/9f5d12f1/attachment.pgp 


More information about the bazaar mailing list