[MERGE] Refactor fetch: add get_data_about_revision_ids to repository, and other changes.
Aaron Bentley
aaron.bentley at utoronto.ca
Wed Aug 22 16:15:58 BST 2007
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Andrew Bennetts wrote:
> Andrew Bennetts wrote:
>> I've addressed all the review comments, but here's a new bundle. The part I
>> want feedback on is the new method name, and its description:
>> item_keys_introduced_by(revision_ids).
>
> Ahem. And here's a *current* bundle, after actually committing the relevant
> changes. Sorry for the noise!
You've introduced a new public interface, but you haven't tested it
directly. In particular, RemoteRepository seems to lack an
implementation of item_keys_introduced_by.
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFGzFMu0F+nu1YWqI0RAofeAJ90F6U+wuDOE8O9ieQt3p7E+IHBtQCfcf5Z
ht/omQFY93iEOsNwCdEEc9s=
=jBvR
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list