[MERGE] Clarify tests in revisionstore_implementations/test_all

Robert Collins robertc at robertcollins.net
Wed Aug 22 09:06:59 BST 2007


This was a test I had to read twice to figure it out because the comment
and the test did not match. So I made a new test that matched the
comment, and altered the test name and comment to match the test.

=== modified file 'bzrlib/tests/revisionstore_implementations/test_all.py'
--- bzrlib/tests/revisionstore_implementations/test_all.py      2007-07-11 16:42:37 +0000
+++ bzrlib/tests/revisionstore_implementations/test_all.py      2007-08-22 07:50:21 +0000
@@ -62,11 +62,18 @@
         # has of None -> True
         self.assertTrue(self.store.has_revision_id('null:', self.transaction))
 
+    def test_get_revision_missing(self):
+        # get_revision('B') -> raises NoSuchRevision
+        self.assertRaises(errors.NoSuchRevision,
+                          self.store.get_revision,
+                          'B',
+                          self.transaction)
+
     def test_get_revision_none(self):
         # get_revision(None) -> raises NoSuchRevision
         self.assertRaises(errors.NoSuchRevision,
                           self.store.get_revision,
-                          'B',
+                          None,
                           self.transaction)
 
     def test_add_signature_text_missing(self):


-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070822/845eadea/attachment.pgp 


More information about the bazaar mailing list