[MERGE][BUG #77533][RFC] ignore files with invalid filenames

Fabio Machado de Oliveira absfabio at terra.com.br
Tue Aug 21 13:09:36 BST 2007


Aaron Bentley escreveu:
> Aaron Bentley has voted tweak.
> Status is now: Semi-approved
> Comment:
> This looks redundant:
> 
> +                        try:
> +                            unicode_path_info = 
> current_path_info[0].decode('utf8')
> +                        except UnicodeDecodeError:
> +                            unicode_path_info = None
> +                        if unicode_path_info is not None:
> +                            if self.target._directory_is_tree_reference(
> +                                current_path_info[0].decode('utf8')):
> 
> Any reason not to use unicode_path_info directly instead of decoding it 
> again?
> 
> Looks fine, otherwise
> 
> For details, see: 
> http://bundlebuggy.aaronbentley.com/request/%3C46BB444C.3020506%40terra.com.br%3E 
> 
> 
> 

There was no reason, fixed that.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: invalid_filenames.patch
Type: text/x-patch
Size: 20622 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070821/e10d5940/attachment.bin 


More information about the bazaar mailing list