[MERGE] Remove change_entry from transform.py

[Robert Collins]

On Tue, 2007-08-21 at 11:33 +1000, Ian Clatworthy wrote:
> Robert Collins wrote:
> > On Tue, 2007-08-21 at 10:57 +1000, Ian Clatworthy wrote:
> >> This patch removes some code that was deprecated in the last release and
> >> that needs to go in order to enable some commit related refactoring. The
> >> high level routine (change_entry) was once used by revert by hasn't been
> >> for some time. It is not used now anywhere that I know of but was
> >> deprecated in 0.90 for the sake of being conservative for API users.
> > 
> > We usually wait a couple of releases to remove things. Why does this
> > need to go?
> 
> Because that (unused) code is the only place in the code, bar commit,
> using (internal) methods in inventory.py - _read_tree_state and
> _forget_tree_state - that I want to get rid of as part of changing how
> SHAs are determined during commit. Right now it does it several times
> when it shouldn't and those methods are the heart of that evilness.

Seems to me you can stop using those methods during commit without
removing them, mark them as deprecated to avoid new users, and delete
them and change_entry in a couple more releases.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070821/82c89856/attachment.pgp