[MERGE] selftest fails if the committer name contains non-ASCII characters
aaron.bentley at utoronto.ca
Mon Aug 20 14:50:11 BST 2007
-----BEGIN PGP SIGNED MESSAGE-----
Lukáš Lalinský wrote:
> On Št, 2007-08-16 at 10:35 -0400, Aaron Bentley wrote:
>> Aaron Bentley has voted tweak.
>> Status is now: Conditionally approved
>> It looks like make_utf8_encoded_stringio uses StringIOWrapper for no
>> reason, since codecs.getwriter wraps it. Other than that, looks okay.
> Here is an update patch that fixes it. There was a new test added to
> bzr.dev in the meantime (test_show_changed_revisions_verbose), so I've
> changed it to use make_utf8_encoded_stringio, as well.
> (The patch isn't based on the previous one, because realized it had
> broken committer-id)
Could someone please review this? I have already voted "approve".
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the bazaar