[MERGE] Return NULL_REVISION instead of None

Martin Pool mbp at canonical.com
Mon Aug 20 05:31:25 BST 2007


Martin Pool has voted tweak.
Status is now: Conditionally approved
Comment:
=== modified file 'bzrlib/revisionspec.py'
--- bzrlib/revisionspec.py      2007-08-07 01:58:45 +0000
+++ bzrlib/revisionspec.py      2007-08-07 20:06:36 +0000
@@ -58,6 +58,8 @@
                  self.rev_id = None
              else:
                  self.rev_id = branch.get_rev_id(self.revno)
+        elif rev_id is None:
+            self.rev_id = None
          else:
              self.rev_id = rev_id

That seems to have the same effect as the following two lines.
Should it be setting it to NULL_REVISION?


For details, see: 
http://bundlebuggy.aaronbentley.com/request/%3C46C24C42.2090708%40utoronto.ca%3E



More information about the bazaar mailing list