[merge][rfc] remove python -O from make check

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> At the moment our 'make check', which is run by pqm, runs
> 
> 	python -Werror ./bzr selftest -v $(tests)
> 	@echo "Running all tests with no locale."
> 	LC_CTYPE= LANG=C LC_ALL= ./bzr selftest -v $(tests)
> 	python -O -Werror ./bzr selftest -v $(tests)
> 
> I think the last check is not really needed.  A while ago we had some
> code which relied on side-effects of assert statements, or used
> asserts in test code where it shouldn't have.  But those have now all
> been cleaned up and I think any attempt to bring them back would be
> caught in review, or at least be pretty obvious if they did cause a
> problem.
> 
> Have you ever had a merge that passed locally with plain selftest, but
> got bounced by this check?  I haven't had that for a long time, if
> ever.
> 
> In an ideal world we'd run it anyway but I'm finding the pqm lag a bit
> annoying, and if we could cut the test time by 33% that would make it
> rather more responsive.  Getting the successful merges through faster
> means you'd hear sooner about whatever does go wrong.
> 
> I wonder if we should also change them to run selftest -1 (stop on
> first error)?  I'd prefer to get information about one error sooner
> than about many errors later.  It's almost always something that I can
> reproduce locally.


I wonder if we wouldn't rather always run with -O. Since we shouldn't be
relying on assert foo to do any actual error checking. (It should only
be used to assert that developers are using the apis properly.)

Other than that, I don't mind pulling out one of the selftests. I think
our bigger lag is just because the LP tests are running at the same
time. When an LP submission isn't pending, I'm usually shocked at how
fast I get a response.

So:

BB:tweak

With the caveat that we probably shouldn't be commenting it out, instead
we should be removing it. And we might consider only running with -O,
rather than only without it.

John
=:->


> 
> 
> 
> ------------------------------------------------------------------------
> 
> # Bazaar merge directive format 2 (Bazaar 0.90)
> # revision_id: mbp at sourcefrog.net-20070817074531-moxyeebc4f19gdqd
> # target_branch: http://sourcefrog.net/bzr/trunk
> # testament_sha1: beb7f975ff0cd189374e3a2ebf1299b03ab4a458
> # timestamp: 2007-08-17 17:45:38 +1000
> # source_branch: http://sourcefrog.net/bzr/faster-make-check
> # base_revision_id: pqm at pqm.ubuntu.com-20070816195834-vvgmajr1s1uk4m9w
> # 
> # Begin patch
> === modified file 'Makefile'
> --- Makefile	2007-08-07 19:33:11 +0000
> +++ Makefile	2007-08-17 07:45:31 +0000
> @@ -29,7 +29,7 @@
>  	python -Werror ./bzr selftest -v $(tests)
>  	@echo "Running all tests with no locale."
>  	LC_CTYPE= LANG=C LC_ALL= ./bzr selftest -v $(tests)
> -	python -O -Werror ./bzr selftest -v $(tests)
> +	## python -O -Werror ./bzr selftest -v $(tests)
>  
>  check-msgeditor:
>  	./bzr --no-plugins selftest -v msgeditor
> 
> # Begin bundle
> IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWZdwokMAAWNfgAAwXeP//1YC
> wIC////wUANM9QiYqrTCSUE2kmyDRpNlPRNlNPUxqaDIaGQcwAAAAAAAAAAJIgUntJgqeaphppH6
> moNPUGj1MjRkHMAAAAAAAAAACSSYjQDUxCNCeibEmagANGI0uGemRuNu0ogThlG2d1D8AEEOh9on
> /z3e5Fv3zzHDUzMT5KcdWbsz4jzO/ws9M3H17vDXJfmUIB/LvPjz9d8oXZN8voJ9nqggy07cWzbh
> lvwJ+SYWNFG8ziLnl7U2MfNeVGFYomfOfXf9ERFazYe4F2mI8yN5A8yBARDqF1jCIjm2Jpau/i6u
> wpJLY0OECyVstXIkXlDWrx3E2uvosvWQqJF/2cQLTItGKV2LLI+oLgSMB7BnYLF9BnJ8S5UmhOWo
> jaSNhBDzWMOGLBayz4XxLg6BcQnqmXEja4NgD8SgmmKy8MaC+qa1DE4kLzDaVZK4pTQJJWCGarRw
> oRKzXoXWJxOVeZVGQTMFF2qTIlbLp1GWos6JDkRb1a8HvdWKCmXBLQ7uJ0sL5sf23Cgxh2PHtit3
> I4aQo5NnhtVUvSOthmb9XvSrHWb2pamBre67IkQDExP92GU1IzDMPNeBeXQ98kR8Kq2O7gYGI47z
> sKRMcqktvkuncGJWKwsHEZpPMs+mp2HFdUvYewXcSwyMy5QrAPSEgbRx4l6guF8XItbWcbhrKtUh
> cXjJs1kpRZsbDAHmTluZwnn5PIVk6gSy8lAKXTjeh6SBUTELMZQIwHk/itNIpTfnL56xKu2Rk+lR
> VrSpFWLtX1libAqdJ5cm8dZh6g83GYnGpuoJf3R0MAJgcN2KBsqyG9VvPhjDwh0OCkVORxeowVxr
> etSZbFtqXPgeKa4bdM2WyFHuKCAyDcPoCj5AOjonMjNOW/ACKgKSHoyW7rEKwI1ueV/SlMlalNPP
> OoSZwX5vVbaSUhqzkKoUujK3tY9k0AxwS76kWXcnXsqJRktm1KF4ZzVaOMqH2UHGb1m63aqnSA01
> p0JcwW0Bw1dHszwO7hQfsizV5X+TFOHIyzIDSDmDDDmUWTitcVv37Vph2Ky5Ljaua1gUL4qc3qkU
> 5szaCx1Gdw7DP/i7kinChIS7hRIY

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGxaiNJdeBCYSNAAMRAh32AJsGnZu1D+41Uo30AA24KVVoeb5UWQCdGlji
zoT6ZWRnHKPNl4IQNB2wfr8=
=CYbu
-----END PGP SIGNATURE-----