[merge][rfc] remove python -O from make check

[Martin Pool]

At the moment our 'make check', which is run by pqm, runs

	python -Werror ./bzr selftest -v $(tests)
	@echo "Running all tests with no locale."
	LC_CTYPE= LANG=C LC_ALL= ./bzr selftest -v $(tests)
	python -O -Werror ./bzr selftest -v $(tests)

I think the last check is not really needed.  A while ago we had some
code which relied on side-effects of assert statements, or used
asserts in test code where it shouldn't have.  But those have now all
been cleaned up and I think any attempt to bring them back would be
caught in review, or at least be pretty obvious if they did cause a
problem.

Have you ever had a merge that passed locally with plain selftest, but
got bounced by this check?  I haven't had that for a long time, if
ever.

In an ideal world we'd run it anyway but I'm finding the pqm lag a bit
annoying, and if we could cut the test time by 33% that would make it
rather more responsive.  Getting the successful merges through faster
means you'd hear sooner about whatever does go wrong.

I wonder if we should also change them to run selftest -1 (stop on
first error)?  I'd prefer to get information about one error sooner
than about many errors later.  It's almost always something that I can
reproduce locally.

-- 
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 200708170745Z-faster-make-check.diff
Type: text/x-diff
Size: 2036 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070817/9fb68c70/attachment.bin