[MERGE] Convert tests.blackbox.test_d* to use internals where appropriate

[Alexander Belchenko]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Daniel Watkins пишет:
> Attached is a fix for tests.blackbox.test_diff (the only 'd' in need of
> attention).

bb:comment

 class TestDiff(DiffBase):

     def test_diff(self):
- -        self.make_example_branch()
- -        file('hello', 'wt').write('hello world!')
- -        self.run_bzr('commit -m fixing hello')
+        tree = super(TestDiff, self).make_example_branch()

^-- super() there

     def test_diff_across_rename(self):
         """The working tree path should always be considered for diffing"""
- -        self.make_example_branch()
+        tree = super(TestDiff, self).make_example_branch()

^-- and super() here

they both seems odd.

IIUC, these tests both use DiffBase.make_example_branch() but they present in
TestDiff and TestCheckoutDiff. It means that these two tests runs twice for the same
data. If it's correct, I'd like to see them extracted in separate TestDiff* class
and run them only once. I don't see any reason to waste selftest time for
duplicates.
- --
[µ]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGwNgozYr338mxwCURAsyXAJ4z2eb/6ZMMzJ3FjfxgGgDIQDUUTQCgi4O5
409YUWxzSekAbbXl4ygbZMI=
=ZJQS
-----END PGP SIGNATURE-----