question about bzrlib.tag

[Martin Pool]

On 8/12/07, Alexander Belchenko <bialix at ukr.net> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> from bzrlib/tags.py class BasicTags:
>
>     def _set_tag_dict(self, new_dict):
>         """Replace all tag definitions
>
>         :param new_dict: Dictionary from tag name to target.
>         """
>         self.branch.lock_read()
>         try:
>             self.branch._transport.put_bytes('tags',
>                 self._serialize_tag_dict(new_dict))
>         finally:
>             self.branch.unlock()
>
> Why this method acquire read lock? This method actually write not read data.

Yes, that seems to be a bug, I've fixed it in http://sourcefrog.net/bzr/tags

-- 
Martin