[MERGE] [0.90] Disable patch verification (broken for CRLF files)
bialix at ukr.net
Mon Aug 13 22:31:55 BST 2007
-----BEGIN PGP SIGNED MESSAGE-----
Aaron Bentley пишет:
> Aaron Bentley wrote:
>> Aaron Bentley wrote:
>>> We recently discovered that patch verification is broken for CRLF files
>>> (and probably CR files, too). The fix appeared simple, but I've run
>>> into problems testing it, so I think the safest things it to disable it
>>> for now. I'll get a fix in before 0.91.
>>> I think it is important to get some kind of fix into 0.90, because it
>>> will be an extremely visible bug for projects using non-LF source files
>>> and bundles/merge-directives.
> Can someone please review this?
I try to follow your patch, but I can't.
You're using 'verified', 'inapplicable' and 'failed'.
But I don't see where they used outside of test suite.
I found only on place in builtins.py:
if verified == 'failed':
warning('Preview patch does not match changes')
if conflict_count != 0:
That's all. Is my grepping correct?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the bazaar