[MERGE] [0.90] Disable patch verification (broken for CRLF files)

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> Aaron Bentley wrote:
>> Aaron Bentley wrote:
> 
>>> We recently discovered that patch verification is broken for CRLF files
>>> (and probably CR files, too).  The fix appeared simple, but I've run
>>> into problems testing it, so I think the safest things it to disable it
>>> for now.  I'll get a fix in before 0.91.
>>> I think it is important to get some kind of fix into 0.90, because it
>>> will be an extremely visible bug for projects using non-LF source files
>>> and bundles/merge-directives.
> 
> Can someone please review this?
> 
> Aaron
> 
> http://bundlebuggy.aaronbentley.com/request/%3C46C05772.3060906%40utoronto.ca%3E

What does it actually cause when merging a "broken" bundle?

I can see that you return "inapplicable", but I don't know if that means
it aborts, or does something else. (I think it means that you are saying
it verification isn't really possible for this object.)

If I'm correct then:

BB:approve

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGwMUrJdeBCYSNAAMRAq27AKC6GEcdDFA5I1JRzvNcZlAjPmPFswCg2hsC
CldImv1GqRtm4f0dFUHUvgU=
=N0WL
-----END PGP SIGNATURE-----