[MERGE] internal glob expansion for all commands on win32 and for invocations from the test suite
Alexander Belchenko
bialix at ukr.net
Sat Aug 11 10:20:52 BST 2007
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Kuno Meyer пишет:
> On 09.08.2007 16:57, Aaron Bentley wrote:
>> Aaron Bentley has voted resubmit.
>> Status is now: Resubmit
>> Comment:
>> As on list: don't skip testing ascii or unicode on case-sensitive
>> platforms. Instead, test case-sensitivity separately from testing
>> ascii/unicode.
>
> - separated tests about case-insensitive expansion from other
> win32-specific tests which cope with '\' as directory separator
>
> - all other glob expansion tests never have been skipped, so ??
>
> - other requests (AB, 09 Aug 2007 09:25:33 -0400) implemented
>
> As earlier mentioned, "bzr selftest wildcard Win32Utils" covers most of
> the new functionality and could be run on Linux before proceeding (as I
> did not test it on that platform).
bb:comment
Your current code is not directory recursive, as I could see.
I.e. when I run
bzr di *.c *.h
I got diff only for files in root directory.
How to force recursive behavior?
Per example, let's imagine I have many changed files
in several nested directories:
a.txt
e.c
e.h
dir/b.txt
dir/f.c
dir/f.h
dir/subdir/c.txt
dir/subdir/subsubdir/d.txt
How can I see diff for *.txt files above?
When I run
bzr di *.txt
I got diff only for a.txt
When I run
bzr di */*.txt
I got diff only for b.txt
So, current code does not handle well deep nested directories.
May be because of my misunderstanding of globs.
But anyway in this case I'd rather bb:abstain than bb:approve.
BTW, if I run
bzr st *.txt
or
bzr di *.txt
Also, I get error if no txt files in my root directory:
$ bzr st *.txt */*.txt
bzr: ERROR: Path(s) do not exist: "*.txt"
Why? Even if I have not such files in current directory,
why bzr should return me error? I'd rather expect it
silently ignore, i.e. pattern search should return
empty list of not found files. But instead bzr blame
me about my pattern "*.txt".
[µ]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFGvX9zzYr338mxwCURAih7AJ0d4Ovblr0q1Plo6SaDaq/Y0bEtegCfWDSH
VBOkxhVnryVMBeHmGwPk4FU=
=DcFu
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list