[MERGE] internal glob expansion for all commands on win32 and for invocations from the test suite

Kuno Meyer kuno.meyer at gmx.ch
Thu Aug 9 07:27:48 BST 2007


> On Thu, 2007-08-09 at 00:19 +0200, Kuno Meyer wrote:
> > --- bzrlib/win32utils.py        2007-07-24 19:40:40 +0000
> > +++ bzrlib/win32utils.py        2007-08-08 22:13:53 +0000
> > @@ -266,7 +266,7 @@
> >      Introduced in bzrlib 0.18.
> >      """
> >      if not file_list:
> > -        return []
> > +        return file_list
> >      import glob
> >      expanded_file_list = []
> >      for possible_glob in file_list:
> 
> 
> This change seems spurious and makes the function harder to use as
> demonstrated elsewhere in your patch where you have to make sorting and
> using it optional. 
> 
> Why have you made this change?

It was necessary because of failing blackbox tests. I can remember the ones for the inventory command (my observation: None->all files, []->no file), but perhaps there were more.

I'll investigate later if you think it'll be worth it.

Kuno
-- 
Ist Ihr Browser Vista-kompatibel? Jetzt die neuesten 
Browser-Versionen downloaden: http://www.gmx.net/de/go/browser



More information about the bazaar mailing list