[MERGE][0.19] Fix passing tracefilename to bzrlib.open_tracefile

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andrew Bennetts wrote:
> Currently, if you pass the 'tracefilename' argument to bzrlib.open_tracefile,
> you get an exception.  This simple bundle fixes that.  It was working in 0.17,
> I haven't checked 0.18.
> 
> This is a useful feature if you want to get logging when using bzrlib outside of
> the 'bzr' executable, and don't want to direct it to ~/.bzr.log.
> 
> Unfortunately, with the current structure of bzrlib/trace.py, it is very
> difficult to test this code path, so I have only tested this manually.
> 
> I think this is simple enough that it should go into 0.19, especially as it is a
> regression.
> 
> -Andrew.
> 

Couldn't you just have a function which stores whatever trace and then
asserts that trace._bzr_log_filename is correct?

Anyway, it seems like a reasonable fix to me.

BB:approve

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGunn4JdeBCYSNAAMRAlaaAJ0Z5CgKa2a5HglGu2n86MtKFO4JlQCgs+LK
hr9rGz5VpcR8jmcbiHOyEZo=
=GVNQ
-----END PGP SIGNATURE-----