[MERGE] Add timing to debug information for -Dhpss
John Arbash Meinel
john at arbash-meinel.com
Wed Aug 8 15:13:10 BST 2007
-----BEGIN PGP SIGNED MESSAGE-----
Ian Clatworthy wrote:
> Ian Clatworthy has voted tweak.
> Status is now: Conditionally approved
> This needs a NEWS entry and a section added to
> doc/developers/profiling.txt. (Stuff like this is always welcome but we
> need to ensure developers know about it.)
> Also, is there a good reason why you don't look for hpss in debug flags
> (and mutter if found) before the previous return statement (line 377) in
> the read_body_bytes() method?
> For details, see:
- -Dhpss was already discussed in NEWS earlier. I don't believe I've added
enough to comment on it. But I can if you feel it is important.
We don't do a check in read_body_bytes:377 because of how the function
works. The *first* call goes out to the network and reads in the whole
stream, buffers it, and then just returns what was requested. Subsequent
calls just return data from the buffer.
Have I missed the 0.19 freeze date? This is a pretty small change
overall, just a bit of extra logging.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the bazaar