[MERGE] repository.reconcile_actions

[Robert Collins]

On Tue, 2007-08-07 at 04:19 -0400, Martin Pool wrote:
> Martin Pool has voted resubmit.
> Status is now: Resubmit
> Comment:
> That seems to make some sense for testing.
> 
> +    def reconcile_actions(self):
> +        """Return a set of actions taken by reconcile on this 
> repository.
> +
> +        :return: A set of actions. e.g. set(['inventory_gc']).
> 
> You should explain a bit more what an 'action' is - looks like just a 
> general string token that's not interpreted?

I'll add that to the docstring.

> Rather than making this specific to reconcile, maybe we should just make 
> it a more generic way to get the capabilities/features of the 
> repository?  get_repository_features or _capabilities, returning a set 
> of strings.  Or alternatively has_feature(name).

Hmm. I guess theres a spectrum. We could have every feature a separate
attribute or method. Or we can group them by type of feature, or we can
have one mega method.

I think I prefer grouping them, but not for any really good reason.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070808/bde73be6/attachment.pgp