[MERGE] fix for a keyerror in finding least common ancestors

Robert Collins robertc at robertcollins.net
Tue Aug 7 23:46:39 BST 2007


On Tue, 2007-08-07 at 11:33 -0400, Aaron Bentley wrote:


> The scheduling of candidates is ordering-sensitive, but for the test
> case, I think we have to assume that 'c' will sort before 'd'.  Either
> that, or brew our own dict, an approach I have no appetite for.

I suggest running the test twice, with 'c' and 'd' in opposite order
then.

{'b': ['c'], 'c': ['d'], 'd': [NULL_REVISION]}
and
{'b': ['d'], 'd': ['c'], 'c': [NULL_REVISION]}

That should be immune to hash variations. Which I've seen happen plenty
of times :).

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070808/fefb46a5/attachment.pgp 


More information about the bazaar mailing list