[MERGE] Add __eq__ and __ne__ methods to Repository objects

Martin Pool mbp at canonical.com
Mon Aug 6 06:32:19 BST 2007


Martin Pool has voted tweak.
Status is now: Conditionally approved
Comment:
I think this is ok.  == and != shouldn't be expensive (do network io) or 
have side effects, but it looks like these don't.

+    * ``Repository`` objects can now be compared with ``==`` and ``!=`` 
to
+      determine if they are the same repository.  (Andrew Bennetts)

That doesn't seem quite accurate: if you reach the same repository over 
different urls they'll be seen as different, won't they?  That's 
probably reasonable as doing otherwise would be too expensive, but it 
seems like the docstring or something should be clear about just what 
comparison does and doesn't do.


For details, see: 
http://bundlebuggy.aaronbentley.com/request/%3C20070806020808.GA23895%40steerpike.home.puzzling.org%3E



More information about the bazaar mailing list