[MERGE] Refactor fetch: add get_data_about_revision_ids to repository, and other changes.

[Robert Collins]

On Fri, 2007-08-03 at 13:36 +1000, Andrew Bennetts wrote:

!tweak

> This particular bundle rearranges fetch.py a little.  Most
> interestingly, it
> moves some of the logic out of fetch.py, and moves it to a new method
> on
> Repository, get_data_about_revision_ids(revision_ids).

This method name is quite opaque. I'd like a better one please:). Its
not just 'data' its a description of the knit elements introduced by the
revision ids. I'm not quite sure how to put this into a method name -
feel free to ring me and we can brainstorm verbally if you like.

I agree with the caching comments you make, but don't see a quick way
out. I'll note that the pack refactoring changes the logistics for this
very heavily. One key thing there is that we get atomic insertions so we
can decide not to worry about write ordering and just write the
inventory as we read it.

Regarding the progress bar, thats really specific to the nature of the
repository being pushed/pulled between. Again using pack based
repositories we won't have the same separation between each file id, so
its just going to be a flatter progress space. I wouldn't worry too much
therefore, as long as it looks ok in your testing, and moves :).

-Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070803/9385535b/attachment.pgp