[MERGE][RFC] C implementation of PatienceSequenceMatcher

John Arbash Meinel john at arbash-meinel.com
Thu Aug 2 17:33:55 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Lukáš Lalinský wrote:
> On Po, 2007-07-23 at 10:58 -0500, John Arbash Meinel wrote:
> 
>> I think your version may be a good starting point, but it needs a small
>> improvement to be 'complete'. We probably just need better Patience tests for
>> this, but the specific issue is a pattern like:
>>


I really, really want to review this. But I just haven't had time. Reviewing C
code like this takes a lot of care, since you have to watch out for NULL
derefs, and malloc/free issues. I've started looking a couple times, and
haven't seen anything obviously wrong yet.

Could someone else give it a look over? I'm nominating Andrew for now, since he
did a really good job with my pyrex stuff. But I realize he may not have time.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGsgdzJdeBCYSNAAMRAoYsAJ9Y0HvhFFjgPp4ytMjTSkN3OWmzhgCeNTHC
BXwMlFkth9ZX6UXq3GduZbA=
=qOR7
-----END PGP SIGNATURE-----



More information about the bazaar mailing list