[MERGE][Bug #129694] WorkingTree.unknowns() does not always return accurate list of unknown files

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Daniel Watkins wrote:
> Attached is a bundle which ensures that WorkingTree.unknowns() does
> return an accurate list of unknown files by ensuring that when the
> WorkingTree is unlocked the cache of ignore definitions is cleared.
> 
> While it does fix this bug, there is still opportunity for stale ignore
> definitions to be used if the tree hasn't been unlocked between the
> changes to .bzrignore and the reference to the ignore definitions.
> 
> 

Another possible way we could do it, would be to keep the stat value for any
files involved in a ignored list check. (In this case .bzrignore and
~/.bazaar/ignore.)
Then if those files change at all, we throw out what we have and start over.

Thoughts?

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGsgVjJdeBCYSNAAMRAsUpAJsHAwfqwM05pxu7zEX8kpsBt+60RwCgzuhT
LlidQxHGpMEFyUVVjZ8UbQY=
=h2jd
-----END PGP SIGNATURE-----