[RFC] Stop using hpss 'Repository.get_revision_graph()'

[Robert Collins]

On Tue, 2007-07-31 at 16:14 -0500, John Arbash Meinel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> In doing some of the debug logging changes for hpss, I came across an
> interesting performance issue.
> 
> Specifically, during 'bzr commit' with a bound branch, we read all of
> revisions.kndx (1,121,084 bytes 23ms) and inventory.kndx (1,175,920 bytes 25ms).
>
> We then end up doing an RPC Repository.get_revision_graph (1,567,374 bytes,
> 1000ms). We actually do this 2 times (second times is 904ms).

That sounds like a bug.

> Now, my server is a bit on the slower side (700MHz PIII). So the time may be a
> bit slower than most people see.
> 
> Anyway, if we just eliminate the RemoteRepo.get_revision_graph() specialized
> function, we would eliminate 3MB of data transfer when committing on a bound
> branch. (And for me, it would also eliminate 2s of commit time).

OTOH you'll degrade things for andrews work when it lands, and mine.

Mine because it won't be reading the full index to access revision
texts, andrews because it won't be reading remote indexes at all to
perform pushes.

-Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070801/34ee0c48/attachment.pgp