[MERGE] Add timing to debug information for -Dhpss

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Blake Winton wrote:
> Martin Pool wrote:
>> On 7/31/07, John Arbash Meinel <john at arbash-meinel.com> wrote:
>>> hpss call:   ('get', '...ot0lstk2590yqhzr-1.kndx')
>>> hpss result:  0.006s ('ok',)
>>> hpss call w/body: ('append', '...ot0lstk2590yqhzr-1.knit', '')
>>> ('\x1f\x8b\x08\x00\x00\x00\x00\x00\x02\xff\xd5S\xd1j\xc3 \x14}\xcfW'...)
>>> hpss write time:  0.001s
>>> hpss result:  0.005s ('appended', '23941')
>>
>> - replace the 'hpss result' with '     result' so that it more clearly
>> matches the previous call
> 
> Ditto 'hpss write time' to '     write time'?
> 
>> I had imagined having the time at the end but maybe the start is ok.
> 
> I don't really understand this comment.  I thought the write time came
> just before the result, at the end...
> 
> Later,
> Blake.
> 

In talking directly with him, he was thinking that you would do:

  result:  ('ok',) 1.000s

We decided that this looked pretty good, though:

hpss call:   'get', '...repository/revisions.kndx'
   result:    0.023s  'ok',
              1121084 body bytes read

So now, we log the specific parameters for the request, and if it is a call
that returns a bunch of bytes in a message body, then we report how many bytes
were read.

It would probably be good if it changed over to KB/MB at appropriate times, but
I scratched enough of my itch for now.

Martin had a few other nice ideas, like creating a summary of what functions
were called how many times (lets you know that .get_revision_graph() is being
called 2x, etc). But for now, I think this is good.

(Hmmm, maybe just an --lsprof like output for the hpss.)

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGr6unJdeBCYSNAAMRAvWCAJ9Xvn5gnFSoZoR1IpCn4VyiifylrgCdH0N3
BVzKU8LJId/wEMlgkcrW3ZQ=
=+g/Z
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: hpss_debug_timing.patch
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20070731/c231c79c/attachment.diff