[RFC] general implementation of glob expansion on win32
kuno.meyer at gmx.ch
Tue Jul 31 19:43:58 BST 2007
On 31.07.2007 17:38, John Arbash Meinel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> Alexander Belchenko wrote:
>> Kuno Meyer ?8H5B:
>>> Hi all
>>> I'd like to get feedback for a patch that implements glob expansion on
>>> Win32 for (almost) all commands. Currently, glob expansion on Windows is
>>> just implemented for the FILE argument of the ``add`` command.
> I think we really just want an easy way to do glob expansion for commands that
> need it. Rather than having it enabled on all commands.
> For example, I don't think glob expansion makes any sense for URL's, and it is
> fairly common that we use them. (Then again, we rarely see a '*' in a URL, but
> '?' becomes fairly possible).
Just wanted to add that any non-matching patterns normally get returned
unmodified, which would certainly be true for URLs.
*But* the current implementation of glob.glob() returns  for URLs in
the form of "<proto>://...", perhaps because of interpreting <proto> as
a drive letter.
So, by restricting glob expansion to file* (and other parameters just
pointing to local files), we are around this corner case.
More information about the bazaar