[MERGE][Bug #111914]selftest options to fail if there are missing dependencies, known-failures, etc

Daniel Watkins D.M.Watkins at warwick.ac.uk
Tue Jul 31 11:54:31 BST 2007


Attached is a bundle adding 'bzr selftest --strict' as per Bug #111914.

Martin Pool wrote:
> Does everything pass in bzr.dev with this merged?
AFAIK, yes.

> You should probably add a note in the testing section of HACKING
> explaining this.
Done.

>> @@ -2206,7 +2207,12 @@
>>              suite = filter_suite_by_re(suite, pattern, exclude_pattern,
>>                  random_order)
>>      result = runner.run(suite)
>> -    return result.wasSuccessful()
>> +    success = result.wasSuccessful()
>> +
>> +    if strict and (result.known_failure_count or result.unsupported):
>> +        success = False
>> +
>> +    return success
> 
> I wonder if evaluation of this should be moved into the result through
> e.g. result.wasStrictlySuccessful()?  Then as we add more results we
> shouldn't need to change this method.
Done.

-- 
Daniel Watkins (Odd_Bloke)
University of Warwick Christian Focus President
University of Warwick Computing Society WUGLUG Liaison Officer
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 111914.bundle
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20070731/16971216/attachment.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070731/16971216/attachment.pgp 


More information about the bazaar mailing list