[bzr-gtk: MERGE] selftest with notification

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jelmer Vernooij wrote:
> On Mon, 2007-07-23 at 13:19 -0400, Aaron Bentley wrote:
>> Here's a patch to bzr-gtk to add notification to the selftest command.
>> This means you can run bzr gselftest in a terminal, and when it
>> terminates, it will notify you that it's finished.
>>
>> Thoughts?
> A commit message appears to be missing, or is that the fault of the
> merge directive format?

The metadata is in the bundle, base64 encoded to protect it from mail
mangling (e.g. by Evolution).  The only data outside the bundle is a
description of how to perform the merge.

> Why did you change the base of cmd_gstatus() from GTKCommand to
> Command ?

User error.  I've already corrected that.

> Other than that, patch looks good - would be nice to have in :-)

Done.

> Eventually I think gselftest should show a GUI window to run the tests
> (perhaps using tribunal, once it's finished?). If you'd want a separate
> command that does just the GUI notification but prints output to the
> console, I think it should be done as an additional argument to "bzr
> selftest" (bzr selftest --gui-notify ?).

I think I'd be happy with a full gui for test running.  Especially if
that would separate the traceback out from the logging.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGpOqR0F+nu1YWqI0RArN3AJ9adf77KSJas9w/SW+xQ/v+O+Qg0gCePAgi
Yjb6ds6rf/QjD3uqgsG4Kmo=
=dHBo
-----END PGP SIGNATURE-----