[MERGE][RFC] C implementation of PatienceSequenceMatcher
John Arbash Meinel
john at arbash-meinel.com
Mon Jul 23 17:03:22 BST 2007
John Arbash Meinel has voted -1.
Status is now: Vetoed
I think this is going in a good direction. But the test suite needs to
be cleaned up to run when the extension module cannot be loaded.
And we need to add some tests for different edge cases that I mentioned
on the list. (And the C version should pass them).
One other thing I just noticed:
I've been using the form:
from X_c import foo_c as foo
from X_py import foo_py as foo
The reason I do that, is so that in tracebacks, or when debugging, etc
you can see quite clearly that you are using the C implementation of the
function. (The __name__ attribute will have 'foo_c' versus 'foo_py' even
though it is accessed as bzrlib.patiencediff.foo).
I know it seems redundant since the full name is 'bzrlib._bar_c.foo_c'
but I think it is still useful.
For details, see:
More information about the bazaar