[RFC] C implementation of PatienceSequenceMatcher

Martin Pool mbp at sourcefrog.net
Sun Jul 22 17:05:59 BST 2007


On 7/22/07, Lukáš Lalinský <lalinsky at gmail.com> wrote:
> So, it doesn't have as significant effect in bzrlib as it has on it's
> own.
>
> The question is, does it make sense to replace the current
> PatienceSequenceMatcher with something like this (the attached code is
> just for illustration, it's not finished yet)? Are "not so awesome"
> performance improvements like this worth the price of including C source
> code in bzrlib?

As John says, this looks like a pretty worthwhile speedup, and since
we've decided to ship Pyrex it's not an additional dependency.  If we
do include this, we need to be careful to get it in early and test it
on as many platforms as we can.

You labeled this just 'rfc' - is this ready to be reviewed?

-- 
Martin



More information about the bazaar mailing list