[MERGE] Comparison cache to speed up diff

John Arbash Meinel john at arbash-meinel.com
Fri Jul 20 23:11:48 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:

...

> 
>> If 'get_file()' is costing 50% of the total time to do 'bzr diff', do you have
>> any indications of why it is slow?
> 
> Knit indices.  Poor locality of reference.  Basically, we need a new
> repository format.
> 
>> It certainly seems like we can save a lot
>> more time by making that faster, than doing diff caching.
> 
> That's 50% of 3.556, or 1.8 seconds.  The diff caching saves about 1
> second.  This is not an either/or situation-- these gains are in the
> same order of magnitude, and are both worth having, imho.
> 
> Aaron

I thought your patch meant that we didn't have to extract the basis
text, since we already know the diff of the current file relative to its
basis revision. Or am I misunderstanding what you have done?

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGoTMkJdeBCYSNAAMRAs/1AKCugPfGFP0lZdDZQuLpbH7tTCuYywCePXuE
Bs6WYItNkWf9LvS3oURA3iM=
=FgOU
-----END PGP SIGNATURE-----



More information about the bazaar mailing list