[RFC] Dirstate blowing up on None as a minikind fingerprint.

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Wouter van Heyst wrote:
> On Sat, Jul 14, 2007 at 10:41:04AM +0200, Wouter van Heyst wrote:
>> Hey all,
>>
>> on the nested-trees branch a test was failing with funny dirstate
>> errors, it turns out because the reference_revision for the entry is
>> None and that got fed into DirState.save() which proceeded to blow up.
>>
>> The attached fix gets rid of that, but it's not directly tested
>> (TestCompositeTree.test_apply_inventory_delta does indirectly).
> 
> Bweh, only now do I notice the missing attachement.
> 
> Wouter van Heyst
> 

+1 if you had a test case which exposed this.

It seems to only happen if you have a nested subtree. So only people using
- --dirstate-with-subtree would ever see it.

It shouldn't be too difficult to create a tree which has an inventory
referencing a subtree with no 'reference_revision', and then just calling
DirState.set_state_from_inventory() with that.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGoPzHJdeBCYSNAAMRArxQAJ9XhxWfUe/euM4gXOae1Jz+xfLA+ACgm13G
5XfqmkA8ykClEx0D2qOVDEw=
=ibvI
-----END PGP SIGNATURE-----