[MERGE] DirState pyrex helpers

Martin Pool mbp at sourcefrog.net
Fri Jul 20 18:18:39 BST 2007


On 7/20/07, John Arbash Meinel <john at arbash-meinel.com> wrote:
> >> > Uh, also you can't rely on ints being 4 characters.  (Unless I'm
> >> > missing something and they reliably are in pyrex?)
> >>
> >> I don't care if they are 4-chars. As long as they are a faster way to
> >> iterate
> >> through memory. I realized I have a typo, in that I used '%4' instead
> >> of '%
> >> sizeof(int)'. But I went ahead and fixed that.
> >
> > I meant '4 bytes'.
>
> Sure. I just switched the code to use 'sizeof(int)' which is more
> correct anyway.

Right, that's what I was trying to say.

> So does this count as a +1 or +1 (conditional). I would like to get this
> merged earlier rather than later for 0.19.

+1 -- I didn't read the updated patch in detail, but if that's what
you've changed we're good to go.

-- 
Martin



More information about the bazaar mailing list