[MERGE][Bug #116143] commit raises UnicodeError (traceback) if LANG is incorrect

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Daniel Watkins wrote:
> Robert Collins wrote:
>> I would **really** rather see some tests. You can use 'make check' to
>> run them in the C locale where unicode is disabled.
> I'm afraid I don't really grok what you're suggesting here...
> 
>> If this is too hard, as the changes are fairly simple and we do have test coverage for the success case, I'm ok with allowing it in.
> It may be too hard, but I'd like to take a shot at it before deciding
> that's the case. :D
> 
> 
> Cheers,

If you run 'make check' we run the test suite 3 times:

python ./bzr selftest
LANG=C python ./bzr selftest
python -O ./bzr selftest

This tests bzr in a normal fashion, and then with LANG=C (so that we
cannot create Unicode files to test that we fall back as appropriate),
and then a test with -O which removes 'assert' statements, to make sure
we don't have any important functionality in an 'assert'.

What Robert is saying is that you can write a test which would fail if
we cannot read/write Unicode filenames, and then run either "make check"
or 'LANG=C ./bzr selftest' manually.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGoOM+JdeBCYSNAAMRAlgjAJ4qPRj6SZ63zI5DkClpHuOus8xd5QCeMxCa
FnDU6bkeSel1h7KB6tZshis=
=+evr
-----END PGP SIGNATURE-----