[MERGE] Deprecate old fns that use InventoryEntry methods that ought to go

Ian Clatworthy ian.clatworthy at internode.on.net
Thu Jul 19 08:31:34 BST 2007


John Arbash Meinel wrote:
> Oh, we should make sure there is a test that it is deprecated... It
> seems unfortunate that we have no test code exercising this already that
> you can just switch to 'self.callDeprecated(change_entry)'

John,

Are you saying that every time we ever deprecate something, we should
have a test that it is deprecated? I agree that's appropriate in certain
cases but, as a blanket rule, it sounds a little excessive to me. I
don't think that's really adding value, is it? Once I delete the code, I
don't expect a test confirming that it no longer exists to stretch the
analogy further.

FWIW, we have 70+ deprecated symbols in the code base and very few tests
(bar the generic ones) along these lines. I'm no TDD expert. I'd add it
if you or anyone else feels strongly about it being the right thing to
do. But it feels like I'm being asked to introduce a call to be piece of
code when there are zero other known calls to that code in the universe
and I want the code nuked at the earliest legal point in time I can.

My 2c,
Ian C.



More information about the bazaar mailing list