What to do about 'revid in ancestry' checks.

Robert Collins robertc at robertcollins.net
Thu Jul 19 04:55:25 BST 2007


On Wed, 2007-07-18 at 23:39 -0400, Aaron Bentley wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Robert Collins wrote:
> > There are multiple places in bzr which do set inclusion tests like
> > 'if rev_id in ancestry'
> > where ancestry is obtained by Repository.get_ancestry.
> > 
> > To avoid scaling problems this needs to be delegated to the repository
> > index, *or* get_ancestry has to return a smart/lazy set object.
> 
> I think set inclusion tests are pretty clearly the domain of the Graph
> object, actually.  Doesn't that make sense to you?

I'm happy to add change bzrlib.get_revision_graph to return a lazy graph
object and then advise people to use that.

-Rob


-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070719/fedae6c5/attachment.pgp 


More information about the bazaar mailing list