[MERGE] delegate graph generation to knits entirely

Robert Collins robertc at robertcollins.net
Thu Jul 19 04:27:52 BST 2007


On Wed, 2007-07-18 at 20:23 -0700, Martin Pool wrote:
> 
> 
> +        if revision_id not in a_weave:
>              raise errors.NoSuchRevision(self, revision_id)
> 
> Maybe this should be the responsibility of a_weave.get_graph too?
> (Maybe it does it already?)  Otherwise it seems likely to
> unnecessarily read the index again, or at least traverse it.
> 
> Aside from that, assuming it passes, it seems ok to me. 

Thats a good point, I'll make sure that that is delegated at the same
time. Want to see the result, or Just Do It ?

-Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070719/2969e677/attachment.pgp 


More information about the bazaar mailing list