What to do about 'revid in ancestry' checks.

Robert Collins robertc at robertcollins.net
Thu Jul 19 04:22:47 BST 2007


There are multiple places in bzr which do set inclusion tests like
'if rev_id in ancestry'
where ancestry is obtained by Repository.get_ancestry.

To avoid scaling problems this needs to be delegated to the repository
index, *or* get_ancestry has to return a smart/lazy set object.

I think its probably clearer to have it delegated to repository, rather
than a smart object *for now*. This is because its not clear that that
'foo in THING' may result in THING doing loads of SFTP requests, whereas
a method call on repository is at least somewhat more predictable.

-Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070719/202d6ca4/attachment.pgp 


More information about the bazaar mailing list