[MERGE][Take two] Show the diff in the commit messages

Goffredo Baroncelli kreijack at tiscalinet.it
Mon Jul 16 20:59:26 BST 2007


Thank for you bug signalation. Before the code can crash if a line prefixed 
with "--"/"++" had a non utf8 valid sequence.

Aaron, can you provide an example where my code does the _commit_ impossible 
or unreadable or unreliable or in any case worse that the actual one?

On Monday 16 July 2007, Aaron Bentley wrote:
> Aaron Bentley has voted -1.
> Status is now: Vetoed
> Comment:
> Detecting metadata lines based on their prefix is not tasteful, and is 
> also not reliable.  For example, removing a file line whose contents are 
> "--\xa0" will produce a diff line "---\x0" which does not indicate a 
> file path and is not utf-8-encoded.
> 
> For details, see: 
> 
http://bundlebuggy.aaronbentley.com/request/%3C200707162039.10687.kreijack%40tiscalinet.it%3E
> 
> 



-- 
gpg key@ keyserver.linux.it: Goffredo Baroncelli (ghigo) <kreijack at inwind.it>
Key fingerprint = CE3C 7E01 6782 30A3 5B87  87C0 BB86 505C 6B2A CFF9
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bzr-ci-diff.bundle.diff
Type: text/x-diff
Size: 48787 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070716/54a75dae/attachment-0001.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070716/54a75dae/attachment-0001.pgp 


More information about the bazaar mailing list