startup warning on win98

Martin Pool mbp at sourcefrog.net
Thu Jul 12 09:43:12 BST 2007


http://bundlebuggy.aaronbentley.com/request/%3Cd80792120706181317l610dbf71j641087722317699a@mail.gmail.com%3E

This patch is still hanging around in BB.  Alexander said he likes the
second part but not the first.  Should I go ahead and merge the second
bit?


=== modified file 'bzrlib/win32utils.py'
--- bzrlib/win32utils.py	2007-02-03 15:02:06 +0000
+++ bzrlib/win32utils.py	2007-06-18 20:05:56 +0000
@@ -47,6 +47,9 @@
     else:
         # don't care about real Windows name, just to force safe operations
         winver = 'Windows 98'
+        sys.stderr.write("bzr: WARNING: "
+            "win98 is known broken, because it doesn't support\n"
+            "shared locking of files (there is no LockFileEx() api)\n")
 else:
     winver = None

@@ -169,7 +172,7 @@
     # at least return windows root directory
     windir = os.environ.get('windir')
     if windir:
-        return os.path.splitdrive(windir) + '/'
+        return os.path.splitdrive(windir)[0] + '/'
     # otherwise C:\ is good enough for 98% users
     return 'C:/'



-- 
Martin



More information about the bazaar mailing list