[MERGE] using NULL_REVISION everywhere

Aaron Bentley aaron.bentley at utoronto.ca
Thu Jul 12 08:42:37 BST 2007


Robert Collins wrote:
> On Thu, 2007-07-12 at 02:07 -0400, Aaron Bentley wrote:
> 
> 
>>> +class TestUncommit(TestCaseWithWorkingTree):
>>> +
>>> +    def test_uncommit_to_null(self):
>>> +        tree = self.make_branch_and_tree('branch')
>>> +        tree.lock_write()
>>> +        revid = tree.commit('a revision')
>>> +        tree.unlock()
>>> +        uncommit.uncommit(tree.branch, tree=tree)
>>> +        self.assertEqual([], tree.get_parent_ids())
>>>
>>> This should go in bzrlib.tests.workingtree_implementations.test_uncommit IMO.
>> You mean create a whole new file for this test?
> 
> Yup. I think we'll probably be adding per-tree uncommit tests of other
> bits too later, so having a dedicated file makes sense to me.

Okay, this bundle should address everything you mentioned, and also adds
documentation as Martin suggested.

Aaron
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nullrevision2.patch
Type: text/x-patch
Size: 213126 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070712/192ff026/attachment-0001.bin 


More information about the bazaar mailing list