[MERGE] Re: windows-only problem with launchpad plugin

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Just forwarding it back to the list with [MERGE] so that BB can pick it up. (I
wanted to vote it in :)

John
=:->


- -------- Original Message --------
Subject: Re: windows-only problem with launchpad plugin
Date: Tue, 10 Jul 2007 15:25:59 +0200
From: Lukáš Lalinský <lalinsky at gmail.com>
To: Bazaar <bazaar at lists.canonical.com>
References: <e01316480707100339q99c0721o391f86e7fe9cdd33 at mail.gmail.com>

On Ut, 2007-07-10 at 20:39 +1000, Martin Pool wrote:
> https://bugs.launchpad.net/bugs/124899
> 
> There seems to be something strange happening with the registration of
> the lp: plugin on Windows.  I can't reproduce it in 0.19dev on Ubuntu.
>  Could anyone investigate this and see if they can reproduce it or
> diagnose it?  I wonder if the plugin code is interacting badly with
> the way things are packaged into a zip on windows.

The problem is that load_from_zip creates a new zipimporter object for
the main zip file, which already has one. This somehow confuses Python
and later on lazy_importing the lp transport it imports
bzrlib.plugins.launchpad again. Letting Python to import from zip files
automatically (thanks to bzrlib.plugins.__path__) seems to fix the
problem.


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGk4pSJdeBCYSNAAMRAjjOAKDMHDCvBEHKK52ZGimNvPmI4KxKcACgl3uI
tF4ukZb4qfxYmeMkdJRE0ik=
=h0QE
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bzr-zipimport.diff
Type: text/x-patch
Size: 3020 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070710/7d626983/attachment.bin