[MERGE] UTF-8 encoding in binary diffs
John Arbash Meinel
john at arbash-meinel.com
Tue Jul 10 14:17:01 BST 2007
John Arbash Meinel has voted +1.
Status is now: Semi-approved
Comment:
We had decided to use utf-8 for this. So that you would have a
"canonical" diff which could be emailed and properly interpreted on the
other side.
Since we now have merge-directive/bundle/submit/emit/whatever for
transmission, I think we can switch this to using the terminal encoding.
However, it will require passing that value around, which goes through a
*lot* of layers. (It passes through InventoryEntries. The total path
from 'bzr diff' through to showing you some text is really long)
So I believe when I looked into making it a parameter, it just had too
many layers that you had to pass 'encoding' through.
Ultimately, I think we really want a better API than 'to_file', which
lets us write things like 'out.write_url()', etc.
Since we have already been hard-coding utf-8 I think this falls under
"incrementally better".
For details, see:
http://bundlebuggy.aaronbentley.com/request/%3Cd06a5cd30707090048l588e49c3wdfb8aaf3379f3b5e%40mail.gmail.com%3E
More information about the bazaar
mailing list