[MERGE] UTF-8 encoding in binary diffs

Jonathan Lange jml at mumak.net
Fri Jul 6 13:57:02 BST 2007


Attached is a fix for bug 110092
(https://bugs.launchpad.net/bzr/+bug/110092), along with a test.

The issue is that the codepath for handling binary files in
show_diff_trees doesn't encode filenames to UTF-8.

The test I've provided isn't particularly good, IMO. In particular,
the fact that it requires StringIO to trigger the bug isn't nice.
Feedback on how to make it more focused is welcome!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: show-diff-trees-110092.diff
Type: text/x-diff
Size: 2849 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070706/f793d567/attachment.bin 

More information about the bazaar mailing list