[rfc] removing LockableFiles

Aaron Bentley aaron.bentley at utoronto.ca
Fri Jul 6 13:52:24 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> So I propose to change things so that Branch, WorkingTree, Repository
> components just have a _transport and a _lock, and then to delete this
> class.

Seems okay to me.  It will mean enhancing some classes to take over
functionality from LockableFiles, e.g. setting permissions.

If control_files goes away, TreeTransform will need a new strategy for
interacting with limbo.

I suppose one option would be for WorkingTree to provide a get_transform
method.  That would allow WorkingTree implementations to supply
different TreeTransform implementations.  I'm thinking of MemoryTree and
a potential RemoteTree.

That may be a YAGNI at this point.  For one thing, WorkingTree could
just provide get_limbo_path.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGjjsI0F+nu1YWqI0RAuq9AJ9hamlXDcPiFg1uPdjRLxskXt7ggQCfStvk
XDf8b5spMS814R0GVCUp/zM=
=dKN6
-----END PGP SIGNATURE-----



More information about the bazaar mailing list